RFR: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url [v4]
Mandy Chung
mchung at openjdk.org
Wed Dec 4 18:30:42 UTC 2024
On Wed, 4 Dec 2024 18:24:26 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Clean up adapting review comments
>
> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>
>> 126:
>> 127: // In case VM is not yet set this property
>> 128: props.putIfAbsent("java.vm.vendor", VENDOR_VM);
>
> Can this system property just be set here for simplicity? The value of `java.vendor` and `java.vm.vendor` system property are the same.
>
> The VM does not need this value until VM initialization completes. It's only needed by StatSampler (jstat).
In fact, VM no longer sets this property. This should be updated to simply do `props.put`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1870075224
More information about the core-libs-dev
mailing list