RFR: 8342035: jlink plugins for setting java.vendor, java.vm.vendor and java.vendor.url [v4]

Henry Jen henryjen at openjdk.org
Wed Dec 4 19:04:48 UTC 2024


On Wed, 4 Dec 2024 18:27:45 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/VersionProps.java.template line 128:
>> 
>>> 126: 
>>> 127:         // In case VM is not yet set this property
>>> 128:         props.putIfAbsent("java.vm.vendor", VENDOR_VM);
>> 
>> Can this system property just be set here for simplicity?  The value of  `java.vendor` and `java.vm.vendor` system property are the same.
>> 
>> The VM does not need this value until VM initialization completes.  It's only needed by StatSampler (jstat).
>
> In fact, VM no longer sets this property.   This should be updated to simply do `props.put`.

It is just for compatibility with other VM implementation. We don't set the property in hotspot with this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21964#discussion_r1870123819


More information about the core-libs-dev mailing list