RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v6]
Taizo Kurashige
duke at openjdk.org
Fri Dec 13 10:13:37 UTC 2024
On Thu, 12 Dec 2024 23:20:51 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add ifdef WINDOWS
>
> test/jdk/java/io/File/GetXSpace.java line 415:
>
>> 413: private static native boolean isCDDrive(String root);
>> 414:
>> 415: private static long[] getCDDriveSpace(String root) throws IOException {
>
> Why not pass the `size` array in to `getCDDriveSpace` as it is already allocated, instead of allocating again and returning?
That makes sense. I fixed it. Thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21799#discussion_r1883689726
More information about the core-libs-dev
mailing list