RFR: 8343342: java/io/File/GetXSpace.java fails on Windows with CD-ROM drive [v6]

Brian Burkhalter bpb at openjdk.org
Fri Dec 13 23:52:37 UTC 2024


On Fri, 13 Dec 2024 10:10:53 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

>> test/jdk/java/io/File/GetXSpace.java line 415:
>> 
>>> 413:     private static native boolean isCDDrive(String root);
>>> 414: 
>>> 415:     private static long[] getCDDriveSpace(String root) throws IOException {
>> 
>> Why not pass the `size` array in to `getCDDriveSpace` as it is already allocated, instead of allocating again and returning?
>
> That makes sense. I fixed it. Thanks.

Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21799#discussion_r1884658146


More information about the core-libs-dev mailing list