RFR: 8346151: Add transformer error logging to VerifyLocalVariableTableOnRetransformTest

[Chris Plummer]

On Fri, 13 Dec 2024 02:21:42 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> In some circumstances ClassFileTransformer.transform can get ClassCircularityError or LinkageError concatenating strings (see JDK-8264667, JDK-8262002).
> VerifyLocalVariableTableOnRetransformTest fails sometimes on Oracle CI.
> The fix adds handling of the errors to get information for analysis.

Changes requested by cjplummer (Reviewer).

test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.java line 259:

> 257:                     + "' of " + classfileBuffer.length + " bytes.");
> 258:             } catch (Throwable t) {
> 259:                 // try to log, save the error for handling by main thread if the logging fails

Suggestion:

                // Try to log. Save the error for handling by main thread if the logging fails.

test/jdk/java/lang/instrument/VerifyLocalVariableTableOnRetransformTest.java line 261:

> 259:                 // try to log, save the error for handling by main thread if the logging fails
> 260:                 try {
> 261:                     transformerException.printStackTrace();

Isn't this suppose to be `t.printStackTrace()`?

-------------

PR Review: https://git.openjdk.org/jdk/pull/22727#pullrequestreview-2503225089
PR Review Comment: https://git.openjdk.org/jdk/pull/22727#discussion_r1884527770
PR Review Comment: https://git.openjdk.org/jdk/pull/22727#discussion_r1884527374