RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v2]

Jim Laskey jlaskey at openjdk.org
Tue Feb 6 13:56:09 UTC 2024


> Currently, add is returning intern(e) == null which will always be false. The correct test is intern(e) == e , that is, true when element is newly added.

Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into 8325255
 - Correct test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17732/files
  - new: https://git.openjdk.org/jdk/pull/17732/files/d119fb97..b8d2d97d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17732&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17732&range=00-01

  Stats: 30 lines in 5 files changed: 19 ins; 1 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/17732.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17732/head:pull/17732

PR: https://git.openjdk.org/jdk/pull/17732


More information about the core-libs-dev mailing list