RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v2]

Roger Riggs rriggs at openjdk.org
Tue Feb 6 15:57:56 UTC 2024


On Tue, 6 Feb 2024 13:56:09 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Currently, add is returning intern(e) == null which will always be false. The correct test is intern(e) == e , that is, true when element is newly added.
>
> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8325255
>  - Correct test

LGTM

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17732#pullrequestreview-1865626163


More information about the core-libs-dev mailing list