RFR: JDK-8325255 jdk.internal.util.ReferencedKeySet::add using wrong test [v2]

[Chen Liang]

On Tue, 6 Feb 2024 13:56:09 GMT, Jim Laskey <jlaskey at openjdk.org> wrote:

>> Currently, add is returning intern(e) == null which will always be false. The correct test is intern(e) == e , that is, true when element is newly added.
>
> Jim Laskey has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8325255
>  - Correct test

With the current code, if we have code like:

var s = "test failed";
add(s);
add(s);

The last 2 calls will both return `true`, right? We should add a test for consecutively adding the same items too.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17732#issuecomment-1930526916