RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v8]
Eirik Bjørsnøs
eirbjo at openjdk.org
Fri Feb 9 12:31:27 UTC 2024
> Please review this PR which suggests we speed up the `Zip64SizeTest` using a small-sized ZIP64 ZIP file specifically created to reproduce the issue being tested.
>
> The disk space requirement of this test is known to cause problems in some builds, see [JDK-8259866](https://bugs.openjdk.org/browse/JDK-8259866)
>
> By using a sparse file, we reduce consumed disk space from 5GB to 266 bytes and also reduce the runtime from ~35 seconds to ~1 seconds on my Macbook Pro.
>
> The PR also fixes the `@summary` tag, which seems to have been copied from an unrelated test.
Eirik Bjørsnøs has updated the pull request incrementally with two additional commits since the last revision:
- Use three dots consistently for representing an ellipsis
- Add zipdetails of the Zip64 extra field in updateCENHeaderToZip64
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/12948/files
- new: https://git.openjdk.org/jdk/pull/12948/files/a6cc978f..9f843fcd
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=12948&range=07
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=12948&range=06-07
Stats: 9 lines in 1 file changed: 6 ins; 0 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/12948.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/12948/head:pull/12948
PR: https://git.openjdk.org/jdk/pull/12948
More information about the core-libs-dev
mailing list