RFR: 8303891: Speed up Zip64SizeTest using a small ZIP64 file [v8]

Lance Andersen lancea at openjdk.org
Fri Feb 9 17:11:04 UTC 2024


On Fri, 9 Feb 2024 12:31:27 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Please review this PR which suggests we speed up the `Zip64SizeTest` using a small-sized ZIP64 ZIP file specifically created to reproduce the issue being tested.
>> 
>> The disk space requirement of this test is known to cause problems in some builds, see [JDK-8259866](https://bugs.openjdk.org/browse/JDK-8259866)
>> 
>> By using a sparse file, we reduce consumed disk space from 5GB to 266 bytes and also reduce the runtime from ~35 seconds to ~1 seconds on my Macbook Pro.
>> 
>> The PR also fixes the `@summary` tag, which seems to have been copied from an unrelated test.
>
> Eirik Bjørsnøs has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Use three dots consistently for representing an ellipsis
>  - Add zipdetails of the Zip64 extra field in updateCENHeaderToZip64

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/12948#pullrequestreview-1872850714


More information about the core-libs-dev mailing list