RFR: 8325506: Ensure randomness is only read from provided SecureRandom object [v3]

[Valerie Peng]

On Tue, 13 Feb 2024 22:30:28 GMT, Weijun Wang <weijun at openjdk.org> wrote:

>> Many crypto service classes require a `SecureRandom` object at initialization. This test goes through each of them and calculates (generate, encrypt, sign,...) twice with the same `SecureRandom` object and ensures the output is the same.
>
> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   assertNotEqualsByteArray

test/lib/jdk/test/lib/Asserts.java line 285:

> 283:      * @param lhs The left hand side of the comparison.
> 284:      * @param rhs The right hand side of the comparison.
> 285:      * @param msg A description of the assumption; {@code null} for a default message.

nit: exceeds 80 chars

test/lib/jdk/test/lib/Asserts.java line 288:

> 286:      * @throws RuntimeException if the assertion is not true.
> 287:      */
> 288:     public static void assertNotEqualsByteArray(byte[] lhs, byte[] rhs, String msg) {

nit: exceeds 80 chars

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17776#discussion_r1493111466
PR Review Comment: https://git.openjdk.org/jdk/pull/17776#discussion_r1493111899