RFR: 8325506: Ensure randomness is only read from provided SecureRandom object [v3]

Weijun Wang weijun at openjdk.org
Sat Feb 17 14:08:12 UTC 2024


On Sat, 17 Feb 2024 01:01:49 GMT, Valerie Peng <valeriep at openjdk.org> wrote:

>> Weijun Wang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   assertNotEqualsByteArray
>
> test/lib/jdk/test/lib/Asserts.java line 285:
> 
>> 283:      * @param lhs The left hand side of the comparison.
>> 284:      * @param rhs The right hand side of the comparison.
>> 285:      * @param msg A description of the assumption; {@code null} for a default message.
> 
> nit: exceeds 80 chars

It has 87 chars, but there are many long lines in this file. For example, line 184 has 113 chars.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17776#discussion_r1493341744


More information about the core-libs-dev mailing list