RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut

Eirik Bjørsnøs eirbjo at openjdk.org
Sat Feb 17 13:06:12 UTC 2024


Please review this test-only cleanup PR in preparation for deprecating `Deflater.getTotalOut()` in JDK-8326096.

This PR replaces various calls in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to `Deflater.getTotalOut()` when formatting some debugging output lines. 

Additionally, various debug output lines claim to print the result of calling `Deflater.getAdler`, but instead prints the output of `Deflater.getTotalOut'. This PR fixes this to print the actual Adler value instead.

Testing and verification: This is a test-only fix affecting only debug output. I have added the `noreg-self` label to the issue.

-------------

Commit messages:
 - Update DeflaterDictionaryTests to use Deflater.getBytesWritten instead of Deflater.getTotalOut

Changes: https://git.openjdk.org/jdk/pull/17901/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17901&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326100
  Stats: 10 lines in 1 file changed: 0 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/jdk/pull/17901.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17901/head:pull/17901

PR: https://git.openjdk.org/jdk/pull/17901


More information about the core-libs-dev mailing list