RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut
Alan Bateman
alanb at openjdk.org
Sun Feb 18 08:23:54 UTC 2024
On Sat, 17 Feb 2024 13:00:08 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this test-only cleanup PR in preparation for deprecating `Deflater.getTotalOut()` in JDK-8326096.
>
> This PR replaces various calls in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to `Deflater.getTotalOut()` with calls to `Deflater.getBytesWritten()` when formatting some debugging output lines.
>
> Additionally, various debug output lines claim to print the result of calling `Deflater.getAdler`, but instead prints the output of `Deflater.getTotalOut'. This PR fixes this to print the actual Adler value instead.
>
> Testing and verification: This is a test-only fix affecting only debug output. I have added the `noreg-self` label to the issue.
The hazard when the format specifiers are all %s.
-------------
Marked as reviewed by alanb (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17901#pullrequestreview-1887122096
More information about the core-libs-dev
mailing list