RFR: 8326100: DeflaterDictionaryTests should use Deflater.getBytesWritten instead of Deflater.getTotalOut [v2]

Eirik Bjørsnøs eirbjo at openjdk.org
Sun Feb 18 10:56:03 UTC 2024


> Please review this test-only cleanup PR in preparation for deprecating `Deflater.getTotalOut()` in JDK-8326096.
> 
> This PR replaces various calls in`test/jdk/java/util/zip/DeflaterDictionaryTests.java` to `Deflater.getTotalOut()` with calls to `Deflater.getBytesWritten()` when formatting some debugging output lines. 
> 
> Additionally, various debug output lines claim to print the result of calling `Deflater.getAdler`, but instead prints the output of `Deflater.getTotalOut'. This PR fixes this to print the actual Adler value instead.
> 
> Testing and verification: This is a test-only fix affecting only debug output. I have added the `noreg-self` label to the issue.

Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:

  Use more specific format specifier %d instead of %s

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17901/files
  - new: https://git.openjdk.org/jdk/pull/17901/files/4f9059a0..aa46ddaf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17901&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17901&range=00-01

  Stats: 9 lines in 1 file changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/17901.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17901/head:pull/17901

PR: https://git.openjdk.org/jdk/pull/17901


More information about the core-libs-dev mailing list