RFR: 8321156: Improve the handling of invalid UTF-8 byte sequences for ZipInputStream::getNextEntry and ZipFile::getComment [v3]

Lance Andersen lancea at openjdk.org
Sun Feb 25 14:17:05 UTC 2024


> Please review this PR which addresses the handling of invalid UTF-8 byte sequences in the entry name of a LOC file header and a Zip file comment which is returned via ZipFile::getComment.
> 
> As part of the change, `ZipFile::getComment` will now return `null` if an invalid UTF-8 byte sequence is encountered while converting the byte array to a String.  The CSR for this change has also been approved.
> 
> Mach5 tiers 1-3 are clean with this change.

Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:

  Updates based on 2nd round of feedback

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17995/files
  - new: https://git.openjdk.org/jdk/pull/17995/files/dfd49101..637acee4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17995&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17995&range=01-02

  Stats: 14 lines in 3 files changed: 6 ins; 0 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/17995.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17995/head:pull/17995

PR: https://git.openjdk.org/jdk/pull/17995


More information about the core-libs-dev mailing list