RFR: 8321156: Improve the handling of invalid UTF-8 byte sequences for ZipInputStream::getNextEntry and ZipFile::getComment [v3]

Jaikiran Pai jpai at openjdk.org
Sun Feb 25 14:58:53 UTC 2024


On Sun, 25 Feb 2024 14:17:05 GMT, Lance Andersen <lancea at openjdk.org> wrote:

>> Please review this PR which addresses the handling of invalid UTF-8 byte sequences in the entry name of a LOC file header and a Zip file comment which is returned via ZipFile::getComment.
>> 
>> As part of the change, `ZipFile::getComment` will now return `null` if an invalid UTF-8 byte sequence is encountered while converting the byte array to a String.  The CSR for this change has also been approved.
>> 
>> Mach5 tiers 1-3 are clean with this change.
>
> Lance Andersen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Updates based on 2nd round of feedback

Thank you for the updates, Lance. The changes look good to me.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17995#pullrequestreview-1899695125


More information about the core-libs-dev mailing list