RFR: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static
Serguei Spitsyn
sspitsyn at openjdk.org
Mon Jan 8 08:03:28 UTC 2024
The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be static.
The method disables/enables suspend of the current virtual thread, a no-op if the current thread is a platform thread. It is confusing for this to be an instance method, it should be static to make it clearer that it doesn't change the target thread.
The notification method `VirtualThread.notifyJvmtiHideFrames` also has to be static as it does not use/need the virtual thread `this` argument.
One detail to underline is that he intrinsic implementation needs to use the argument #0 instead of #1.
Testing:
- The mach5 tiers 1-6 show no regressions
-------------
Commit messages:
- 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static
Changes: https://git.openjdk.org/jdk/pull/17298/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17298&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8322744
Stats: 15 lines in 5 files changed: 0 ins; 0 del; 15 mod
Patch: https://git.openjdk.org/jdk/pull/17298.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17298/head:pull/17298
PR: https://git.openjdk.org/jdk/pull/17298
More information about the core-libs-dev
mailing list