RFR: 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Jan 11 13:09:39 UTC 2024
> The notification method `VirtualThread.notifyJvmtiDisableSuspend` should be static.
> The method disables/enables suspend of the current virtual thread, a no-op if the current thread is a platform thread. It is confusing for this to be an instance method, it should be static to make it clearer that it doesn't change the target thread.
> The notification method `VirtualThread.notifyJvmtiHideFrames` also has to be static as it does not use/need the virtual thread `this` argument.
> One detail to underline is that he intrinsic implementation needs to use the argument #0 instead of #1.
>
> Testing:
> - The mach5 tiers 1-6 show no regressions
Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge
- 8322744: VirtualThread.notifyJvmtiDisableSuspend should be static
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/17298/files
- new: https://git.openjdk.org/jdk/pull/17298/files/2b684607..66bcce95
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=17298&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=17298&range=00-01
Stats: 17642 lines in 345 files changed: 12363 ins; 3111 del; 2168 mod
Patch: https://git.openjdk.org/jdk/pull/17298.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/17298/head:pull/17298
PR: https://git.openjdk.org/jdk/pull/17298
More information about the core-libs-dev
mailing list