RFR: 8319463: ClassSignature should have superclass and superinterfaces as ClassTypeSig [v4]

Adam Sotona asotona at openjdk.org
Mon Jan 8 11:41:24 UTC 2024


On Fri, 5 Jan 2024 23:06:30 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Discovered while writing a test for #16513 that `ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet [JVM Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100) requires it to be one. This patch adds such a requirement to the accessors, factories, and the parsing logic.
>
> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8319463: ClassSignature should have superclass and superinterfaces as ClassTypeSig

The patch looks good to me.

-------------

Marked as reviewed by asotona (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16514#pullrequestreview-1808894111


More information about the core-libs-dev mailing list