RFR: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order [v3]

Alan Bateman alanb at openjdk.org
Tue Jan 9 18:23:22 UTC 2024


On Tue, 9 Jan 2024 18:13:43 GMT, Mandy Chung <mchung at openjdk.org> wrote:

>> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph for modules with a main class.  It stores the name of the initial module and the generated `SystemModules` class name in two arrays that can be obtained from `SystemModulesMap::moduleNames` and `SystemModulesMap::classNames`.   The elements in the array returned by `classNames()` are supposed to correspond to the elements in the array returned by `moduleNames()`.    However, the implementation sorts both arrays by the value of the elements. 
>> 
>> This fix is simple and write the correct class names and not to sort the values separately.
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comment

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17316#pullrequestreview-1811743456


More information about the core-libs-dev mailing list