Integrated: 8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order

Mandy Chung mchung at openjdk.org
Tue Jan 9 22:07:34 UTC 2024


On Tue, 9 Jan 2024 00:17:48 GMT, Mandy Chung <mchung at openjdk.org> wrote:

> One optimization of Jlink SystemModulesPlugin pre-resolves the module graph for modules with a main class.  It stores the name of the initial module and the generated `SystemModules` class name in two arrays that can be obtained from `SystemModulesMap::moduleNames` and `SystemModulesMap::classNames`.   The elements in the array returned by `classNames()` are supposed to correspond to the elements in the array returned by `moduleNames()`.    However, the implementation sorts both arrays by the value of the elements. 
> 
> This fix is simple and write the correct class names and not to sort the values separately.

This pull request has now been integrated.

Changeset: f3be138e
Author:    Mandy Chung <mchung at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f3be138eb80c9e7f6cc21afb75cda9e49b667c8a
Stats:     290 lines in 6 files changed: 282 ins; 0 del; 8 mod

8322809: SystemModulesMap::classNames and moduleNames arrays do not match the order

Reviewed-by: alanb

-------------

PR: https://git.openjdk.org/jdk/pull/17316


More information about the core-libs-dev mailing list