RFR: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I

Iris Clark iris at openjdk.org
Tue Jan 30 23:12:30 UTC 2024


On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this test-only PR which improves test coverage of `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i" characters with their latin cousins. 
> 
> The test `CompactStrings/RegionMatches.java` currently includes cases comparing these characters against the lowercase latin "i" character, but not against the corresponding uppercase latin "I" character. It would be good to add test cases for the uppercase I as well.
> 
> This was originally found in #12637, which was closed without being integrated. I think this test coverage enhancement is worth rescuing from that PR, where it did prove to catch a regression.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/17639#pullrequestreview-1852564646


More information about the core-libs-dev mailing list