Integrated: 8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I
Eirik Bjørsnøs
eirbjo at openjdk.org
Tue Jan 30 23:56:10 UTC 2024
On Tue, 30 Jan 2024 19:57:01 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
> Please review this test-only PR which improves test coverage of `String.regionMatches` when comparing the Turkic "dotted I" and "dotless i" characters with their latin cousins.
>
> The test `CompactStrings/RegionMatches.java` currently includes cases comparing these characters against the lowercase latin "i" character, but not against the corresponding uppercase latin "I" character. It would be good to add test cases for the uppercase I as well.
>
> This was originally found in #12637, which was closed without being integrated. I think this test coverage enhancement is worth rescuing from that PR, where it did prove to catch a regression.
This pull request has now been integrated.
Changeset: c3c1d5bd
Author: Eirik Bjørsnøs <eirbjo at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/c3c1d5bd12f80c6a720e431961e90b09c2d972f9
Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
8324998: Add test cases for String.regionMatches comparing Turkic dotted/dotless I with uppercase latin I
Reviewed-by: naoto, iris
-------------
PR: https://git.openjdk.org/jdk/pull/17639
More information about the core-libs-dev
mailing list