RFR: 8325525: Create jtreg test case for JDK-8325203 [v2]

Alexey Semenyuk asemenyuk at openjdk.org
Wed Jul 3 17:02:23 UTC 2024


On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P <duke at openjdk.org> wrote:

>> Created jtreg test case for [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>> 
>> The JpackageTest created tests that the child process started from the app launched by jpackage launcher is not automatically terminated when the the launcher is terminated.
>
> Vanitha B P has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8325525 Addressed review comments

test/jdk/tools/jpackage/share/JpackageTest.java line 79:

> 77:             // parse to get regedit PID
> 78:             regeditPid = Long.parseLong(pidStr.split("=", 2)[1]);
> 79:             logger.info("Regedit PID is " + regeditPid);

We use `TKit.log()` for logging in jpackage tests. You can do `TKit.log("Regedit PID is " + regeditPid)`

test/jdk/tools/jpackage/share/JpackageTest.java line 97:

> 95:                 throw new RuntimeException(
> 96:                         "Test failed: Third party software is terminated");
> 97:             }

Use `TKit.assertTrue(isAlive, "Check is regedit process is alive");` instead

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19536#discussion_r1664497233
PR Review Comment: https://git.openjdk.org/jdk/pull/19536#discussion_r1664499364


More information about the core-libs-dev mailing list