RFR: 8325525: Create jtreg test case for JDK-8325203 [v2]

Vanitha B P duke at openjdk.org
Thu Jul 4 14:58:21 UTC 2024


On Wed, 3 Jul 2024 16:57:49 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Vanitha B P has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8325525 Addressed review comments
>
> test/jdk/tools/jpackage/share/JpackageTest.java line 79:
> 
>> 77:             // parse to get regedit PID
>> 78:             regeditPid = Long.parseLong(pidStr.split("=", 2)[1]);
>> 79:             logger.info("Regedit PID is " + regeditPid);
> 
> We use `TKit.log()` for logging in jpackage tests. You can do `TKit.log("Regedit PID is " + regeditPid)`

log(String) is not public in TKit; cannot be accessed from outside package

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19536#discussion_r1665819402


More information about the core-libs-dev mailing list