RFR: 8336844: ZipConstants64 defines duplicate constants EXTID_ZIP64 and ZIP64_EXTID

Sat Jul 20 02:18:12 UTC 2024

On Fri, 19 Jul 2024 19:35:14 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:

> This change deduplicates constants in ZipConstants64 for the Zip64 Extended Information Extra Field Header ID (see APPNOTE.TXT 4.5.3).
> 
> I think there are arguments for consolidating on either `EXTID_ZIP64` or `ZIP64_EXTID`. The PR currently consolidates on `EXTID_ZIP64`, `ZIP64_EXTID` is also an option if there's a preference for that.
> 
> I noticed this while working on a zip64 bug in [JDK-8328995](https://bugs.openjdk.org/browse/JDK-8328995), I was reviewing places that handled zip64 extra fields and initially missed some because I was only looking at one of the constants.

I updated the copyright dates. Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20264#issuecomment-2240861834