Integrated: 8336844: ZipConstants64 defines duplicate constants EXTID_ZIP64 and ZIP64_EXTID
Liam Miller-Cushon
cushon at openjdk.org
Mon Jul 22 17:23:34 UTC 2024
On Fri, 19 Jul 2024 19:35:14 GMT, Liam Miller-Cushon <cushon at openjdk.org> wrote:
> This change deduplicates constants in ZipConstants64 for the Zip64 Extended Information Extra Field Header ID (see APPNOTE.TXT 4.5.3).
>
> I think there are arguments for consolidating on either `EXTID_ZIP64` or `ZIP64_EXTID`. The PR currently consolidates on `EXTID_ZIP64`, `ZIP64_EXTID` is also an option if there's a preference for that.
>
> I noticed this while working on a zip64 bug in [JDK-8328995](https://bugs.openjdk.org/browse/JDK-8328995), I was reviewing places that handled zip64 extra fields and initially missed some because I was only looking at one of the constants.
This pull request has now been integrated.
Changeset: 8438c585
Author: Liam Miller-Cushon <cushon at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/8438c5853f4ae5cef4e861cd0b3952371c886f45
Stats: 12 lines in 6 files changed: 0 ins; 2 del; 10 mod
8336844: ZipConstants64 defines duplicate constants EXTID_ZIP64 and ZIP64_EXTID
Reviewed-by: jpai, vtewari, lancea
-------------
PR: https://git.openjdk.org/jdk/pull/20264
More information about the core-libs-dev
mailing list