RFR: 8334755: Asymptotically faster implementation of square root algorithm [v35]
fabioromano1
duke at openjdk.org
Wed Jul 24 13:23:37 UTC 2024
On Wed, 24 Jul 2024 11:46:03 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Made normalization consistent with that of the C code in the paper
>
> The aim is not about having even more efficient code (yours is already faster than the existing algorithm), but to have simpler code.
>
> The two denormalization code snippets, while based on the same underlying math, are quite different in shape. Having just one denormalization code should be easier to read, understand, check, compare to the paper, and (possibly) evolve.
@rgiulietti I simplified the code to fit the normalization/unnormalization with that of the paper's C code.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/19710#issuecomment-2247920751
More information about the core-libs-dev
mailing list