RFR: 8334755: Asymptotically faster implementation of square root algorithm [v35]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Jul 26 11:58:37 UTC 2024


On Wed, 24 Jul 2024 13:20:31 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> The aim is not about having even more efficient code (yours is already faster than the existing algorithm), but to have simpler code.
>> 
>> The two denormalization code snippets, while based on the same underlying math, are quite different in shape. Having just one denormalization code should be easier to read, understand, check, compare to the paper, and (possibly) evolve.
>
> @rgiulietti I simplified the code to fit the normalization/unnormalization with that of the paper's C code.

@fabioromano1 I'll resume reviewing the PR sometimes next week, so you have some days left for some last-minute enhancements ;-)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19710#issuecomment-2252605117


More information about the core-libs-dev mailing list