RFR: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute [v4]
Chen Liang
liach at openjdk.org
Mon Jul 29 22:00:40 UTC 2024
On Mon, 29 Jul 2024 12:32:10 GMT, Chen Liang <liach at openjdk.org> wrote:
>> As discussed in offline meeting, the max stack and locals information are part of the code attribute and not meaningful for buffered code elements. Computation would be costly and these see no real usage during transformations. Thus, the proposed solution is to move these APIs to be CodeAttribute specific, as this is already how all these APIs' users are using.
>>
>> Also removed useless `Writable` on buffered models, and fixed `BufferedMethodBuilder::code` implementation.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> Spacing style issue
>
> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
Thanks for the reviews!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20338#issuecomment-2257080060
More information about the core-libs-dev
mailing list