Integrated: 8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute

Chen Liang liach at openjdk.org
Mon Jul 29 22:00:41 UTC 2024


On Thu, 25 Jul 2024 22:41:08 GMT, Chen Liang <liach at openjdk.org> wrote:

> As discussed in offline meeting, the max stack and locals information are part of the code attribute and not meaningful for buffered code elements. Computation would be costly and these see no real usage during transformations. Thus, the proposed solution is to move these APIs to be CodeAttribute specific, as this is already how all these APIs' users are using.
> 
> Also removed useless `Writable` on buffered models, and fixed `BufferedMethodBuilder::code` implementation.

This pull request has now been integrated.

Changeset: ab27090a
Author:    Chen Liang <liach at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/ab27090aa085283233851410827767785b3b7b1f
Stats:     229 lines in 13 files changed: 142 ins; 64 del; 23 mod

8337225: Demote maxStack and maxLocals from CodeModel to CodeAttribute

Reviewed-by: asotona

-------------

PR: https://git.openjdk.org/jdk/pull/20338


More information about the core-libs-dev mailing list