RFR: 8319457: Update jpackage to support WiX Toolset 4 on Windows [v3]

Alexey Semenyuk asemenyuk at openjdk.org
Tue Jun 4 14:01:41 UTC 2024


On Tue, 4 Jun 2024 01:07:15 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   EOLs restored
>
> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/MsiInstallerStrings_de.wxl line 1:
> 
>> 1: <?xml version = '1.0' encoding = 'utf-8'?>
> 
> MsiInstallerStrings_de(ja,zh_CA).wxl are probably saved in wrong format. Can you double check if it is intentional change?

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19318#discussion_r1626070251


More information about the core-libs-dev mailing list