RFR: 8319457: Update jpackage to support WiX v4 and v5 on Windows [v4]

Alexey Semenyuk asemenyuk at openjdk.org
Wed Jun 5 15:41:59 UTC 2024


On Tue, 4 Jun 2024 01:20:15 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> Do we need to handle default case for unknown wix type? In same cases you have default -> throw new IllegalArgumentException(); and in some you do not have.

Good catch. I'll update the code to make `switch(wixVersion) ...`  expressions consistent as follows:

switch (wixVersion) {
  case Wix3 -> {}
  case WiX4 -> {}
  default -> throw new IllegalArgumentException();
}

-------------

PR Comment: https://git.openjdk.org/jdk/pull/19318#issuecomment-2150382290


More information about the core-libs-dev mailing list