RFR: 8333749: Consolidate ConstantDesc conversion in java.base [v2]
Chen Liang
liach at openjdk.org
Thu Jun 6 19:24:14 UTC 2024
On Thu, 6 Jun 2024 19:01:02 GMT, Claes Redestad <redestad at openjdk.org> wrote:
>> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> mt -> md (desc)
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java line 471:
>
>> 469: case Allocate allocate -> emitAllocBuffer(allocate);
>> 470: case BoxAddress boxAddress -> emitBoxAddress(boxAddress);
>> 471: case SegmentBase _ -> emitSegmentBase();
>
> Seem a bit too far detached from the changes at hand for a drive-by code cleanup?
My uncontrollable urges to fix these minor IDE warnings... Please allow these fixes, as I have similar changes in ProxyGenerator as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19585#discussion_r1630100819
More information about the core-libs-dev
mailing list