RFR: 8333749: Consolidate ConstantDesc conversion in java.base [v3]

Claes Redestad redestad at openjdk.org
Fri Jun 7 08:12:15 UTC 2024


On Thu, 6 Jun 2024 19:12:35 GMT, Chen Liang <liach at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/runtime/SwitchBootstraps.java line 469:
>> 
>>> 467:                             // o instanceof Wrapped(float)
>>> 468:                             cb.aload(SELECTOR_OBJ);
>>> 469:                             cb.instanceOf(classDesc(Wrapper.forBasicType(classLabel)
>> 
>> I have a patch somewhere to cache the wrapper class desc in `sun.invoke.util.Wrapper`, both as a micro-optimization and to help disambigutate the unfortunately named (my bad) `Wrapper::classDescriptor` method. Maybe we can roll that into this..?
>
> Feel free, or you can get your patch merged first and then I base off yours if yours is ready.

Created a PR you could fold into this, if you'd like: https://github.com/liachmodded/jdk/pull/1

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19585#discussion_r1630816783


More information about the core-libs-dev mailing list