RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v2]

Brett Okken duke at openjdk.org
Sat Jun 8 16:23:16 UTC 2024


On Sat, 8 Jun 2024 06:40:39 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> After PR #16245, C2 optimizes stores into primitive arrays by combining values ​​into larger stores. In the UUID.toString method, ByteArrayLittleEndian can be removed, making the code more elegant and faster.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add comments

src/java.base/share/classes/jdk/internal/util/HexDigits.java line 122:

> 120:      * @param value to convert
> 121:      */
> 122:     public static void putHex(byte[] buffer, int off, int i) {

Should there be 2 methods - for 2 and 4 bytes respectively?
Does c2 optimize 8 byte writes as well?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19610#discussion_r1632068305


More information about the core-libs-dev mailing list