RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v2]
Bernd
duke at openjdk.org
Sat Jun 8 20:40:13 UTC 2024
On Sat, 8 Jun 2024 06:40:39 GMT, Shaojin Wen <duke at openjdk.org> wrote:
>> After PR #16245, C2 optimizes stores into primitive arrays by combining values into larger stores. In the UUID.toString method, ByteArrayLittleEndian can be removed, making the code more elegant and faster.
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>
> add comments
Changes requested by ecki at github.com (no known OpenJDK username).
src/java.base/share/classes/jdk/internal/util/HexDigits.java line 120:
> 118: * @param buffer byte buffer to copy into
> 119: * @param off insert point
> 120: * @param value to convert
The parameter is called i. Maybe also add "Only least significant 16 bits are used." Even when it's only a internal api.
-------------
PR Review: https://git.openjdk.org/jdk/pull/19610#pullrequestreview-2105936973
PR Review Comment: https://git.openjdk.org/jdk/pull/19610#discussion_r1632105594
More information about the core-libs-dev
mailing list