RFR: 8333358: java/io/IO/IO.java test fails intermittently

[Naoto Sato]

On Mon, 10 Jun 2024 12:29:32 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Please review this fix for an intermittent test failure.
> 
> On some configurations, the default `expect` timeout of 10 seconds is insufficient. It is increased to 20; it's hard to imagine a configuration for which that new value would still be insufficient, but we'll see.
> 
> Aside from that, test-generated diagnostics are improved: the version of the `expect` command and the duration of each test method are recorded. `output.exp` is modified for robustness and clear indication of the timeout condition.
> 
> I was reminded, out-of-band, that test timeouts should be scaled with `test.timeout.factor`. I propose to integrate this PR first and then separately update all the affected tests to scale their `expect` timeouts.

LGTM

test/jdk/java/io/IO/IO.java line 190:

> 188: 
> 189: 
> 190:     // adapted from https://raw.githubusercontent.com/junit-team/junit5/main/documentation/src/test/java/example/timing/TimingExtension.java

Probably better to refer to the user guide on the web (https://junit.org/junit5/docs/snapshot/user-guide/#extensions-lifecycle-callbacks-before-after-execution)

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/19627#pullrequestreview-2108625709
PR Review Comment: https://git.openjdk.org/jdk/pull/19627#discussion_r1633749196