RFR: 8333358: java/io/IO/IO.java test fails intermittently [v2]

Pavel Rappo prappo at openjdk.org
Tue Jun 11 09:01:49 UTC 2024


> Please review this fix for an intermittent test failure.
> 
> On some configurations, the default `expect` timeout of 10 seconds is insufficient. It is increased to 20; it's hard to imagine a configuration for which that new value would still be insufficient, but we'll see.
> 
> Aside from that, test-generated diagnostics are improved: the version of the `expect` command and the duration of each test method are recorded. `output.exp` is modified for robustness and clear indication of the timeout condition.
> 
> I was reminded, out-of-band, that test timeouts should be scaled with `test.timeout.factor`. I propose to integrate this PR first and then separately update all the affected tests to scale their `expect` timeouts.

Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:

  Change url as suggested in review

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/19627/files
  - new: https://git.openjdk.org/jdk/pull/19627/files/da0c0b7b..21f63a98

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=19627&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=19627&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/19627.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/19627/head:pull/19627

PR: https://git.openjdk.org/jdk/pull/19627


More information about the core-libs-dev mailing list