RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v18]

[Adam Sotona]

On Thu, 6 Jun 2024 12:17:14 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - reverted static initialization of ConstantPoolBuilder and CP entries
>>  - fixed naming conventions
>
> src/java.base/share/classes/java/lang/invoke/GenerateJLIClassesHelper.java line 564:
> 
>> 562:             clb.withFlags(ACC_PRIVATE | ACC_FINAL | ACC_SUPER)
>> 563:                .withSuperclass(InvokerBytecodeGenerator.INVOKER_SUPER_DESC)
>> 564:                .with(SourceFileAttribute.of(className.substring(className.lastIndexOf('/') + 1)));
> 
> Maybe we can keep the classDesc from ofInternalName and use its displayName.

I don't see any benefits, both ways are sub-stringing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1642789436