RFR: 8294960: Convert java.base/java.lang.invoke package to use the Classfile API to generate lambdas and method handles [v18]

Adam Sotona asotona at openjdk.org
Mon Jun 17 13:14:17 UTC 2024


On Thu, 6 Jun 2024 12:22:41 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - reverted static initialization of ConstantPoolBuilder and CP entries
>>  - fixed naming conventions
>
> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java line 96:
> 
>> 94:         }
>> 95:     };
>> 96:     record MethodBody(Consumer<CodeBuilder> code) implements Consumer<MethodBuilder> {
> 
> Why do we have these 2 instead of a noop record field builder consumer (flags is already set in withField, and MethodBody should just be direct usage of withMethodBody)
> 
> Seems the problem is in CF implemetnation side. Then these should be part of CF implementation details.

There is no problem if you can rely on lambdas ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17108#discussion_r1642793485


More information about the core-libs-dev mailing list