RFR: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal [v13]

Shaojin Wen duke at openjdk.org
Wed Jun 26 13:23:10 UTC 2024


On Wed, 26 Jun 2024 12:50:38 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> I like the new implementation, the code is cleaner, is your suggestion to revert to the original version due to smaller changes?
>
> In principle, you should not arbitrarily change code that is correct, and only limit your changes to reach the goal of the PR.
> My suggestion is the minimal change required, yours is more than strictly needed.

Got it, should I change it back?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19730#discussion_r1654828664


More information about the core-libs-dev mailing list