RFR: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal [v13]

Raffaello Giulietti rgiulietti at openjdk.org
Wed Jun 26 13:56:11 UTC 2024


On Wed, 26 Jun 2024 13:20:58 GMT, Shaojin Wen <duke at openjdk.org> wrote:

>> In principle, you should not arbitrarily change code that is correct, and only limit your changes to reach the goal of the PR.
>> My suggestion is the minimal change required, yours is more than strictly needed.
>
> Got it, should I change it back?

If there's nothing else, no, there's no need to switch back.

Sorry if I sound pedantic on some principles that I feel are important for the good health of OpenJDK ;-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19730#discussion_r1654905660


More information about the core-libs-dev mailing list