Integrated: 8327208: Remove unused method java.util.jar.Manifest.make72Safe

Eirik Bjørsnøs eirbjo at openjdk.org
Tue Mar 5 08:41:55 UTC 2024


On Mon, 4 Mar 2024 09:55:09 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this cleanup PR which suggests we remove the package-private, unused and deprecated method `java.util.jar.Manifest.make72Safe`.
> 
> This method was marked deprecated after a cleanup/refactoring in [JDK-8066619](https://bugs.openjdk.org/browse/JDK-8066619) caused it to fall out of use. It should rather be removed.
> 
> Some tests reference the `make72Safe` methods in comment, or implement the legacy versions of the same logic to simulate pre JDK 11 line break behavior of `Manifest.write`. These comments and method names are adjusted to not reference the now removed method.
> 
> This change was initially discussed here: https://mail.openjdk.org/pipermail/core-libs-dev/2024-February/119819.html

This pull request has now been integrated.

Changeset: e9adceba
Author:    Eirik Bjørsnøs <eirbjo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/e9adcebaf242843fe2004b01747b5a930b62b291
Stats:     33 lines in 3 files changed: 2 ins; 21 del; 10 mod

8327208: Remove unused method java.util.jar.Manifest.make72Safe

Reviewed-by: lancea, iris, jpai

-------------

PR: https://git.openjdk.org/jdk/pull/18104


More information about the core-libs-dev mailing list