RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket [v7]

[Christoph Langer]

On Wed, 6 Mar 2024 14:42:09 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:

>> Christoph Langer has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Indentation
>>  - Merge branch 'master' into JDK-8325579
>>  - Review feedback
>>  - Rename back to LdapSSLHandshakeFailureTest to ease reviewing
>>  - Merge branch 'master' into JDK-8325579
>>  - Typo
>>  - Merge branch 'master' into JDK-8325579
>>  - Rename test and refine comment
>>  - Enhance test
>>  - JDK-8325579
>
> src/java.naming/share/classes/module-info.java line 42:
> 
>> 40:  *         <br>The value of this environment property specifies the fully
>> 41:  *         qualified class name of the socket factory used by the LDAP provider.
>> 42:  *         This class must implement the javax.net.SocketFactory abstract class.
> 
> We need to mention here that `getDefault` method needs to be implemented by the provided socket factory class.
> 
>  Something like: `and provide an implementation of the static "getDefault()" method that returns an instance of the socket factory.`
> The CSR needs to be updated too.

Good point. I will amend that in both, source code and CSR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1516570214