RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket [v7]

Christoph Langer clanger at openjdk.org
Thu Mar 14 21:59:54 UTC 2024


On Thu, 7 Mar 2024 17:38:24 GMT, Christoph Langer <clanger at openjdk.org> wrote:

>> src/java.naming/share/classes/module-info.java line 42:
>> 
>>> 40:  *         <br>The value of this environment property specifies the fully
>>> 41:  *         qualified class name of the socket factory used by the LDAP provider.
>>> 42:  *         This class must implement the javax.net.SocketFactory abstract class.
>> 
>> We need to mention here that `getDefault` method needs to be implemented by the provided socket factory class.
>> 
>>  Something like: `and provide an implementation of the static "getDefault()" method that returns an instance of the socket factory.`
>> The CSR needs to be updated too.
>
> Good point. I will amend that in both, source code and CSR.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17797#discussion_r1525530951


More information about the core-libs-dev mailing list