RFR: JDK-8315575: Retransform of record class with record component annotation fails with CFE [v3]
Alex Menkov
amenkov at openjdk.org
Wed Mar 13 01:02:50 UTC 2024
> RecordComponent class has _attributes_count field.
> The only user of the field is JvmtiClassFileReconstituter. Incorrect value of the field causes producing incorrect data for Record attribute.
> Parsing Record attribute ClassFileParser skips unknown attributes and may skip RuntimeInvisibleAnnotations/RuntimeInvisibleTypeAnnotations.
> Also annotations can be changed (added/removed) by class redefinition.
> The fix removes attributes_count from RecordComponent; JvmtiClassFileReconstituter calculates correct attributes_count generating class bytes.
>
> Testing:
> - tier1,tier2,hs-tier5-svc;
> - redefineClasses/retransformClasses tests:
> - test/jdk/java/lang/instrument
> - test/hotspot/jtreg/serviceability/jvmti/RedefineClasses
> - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses
> - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RetransformClasses
Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
removed attributes_count from RecordComponent
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/18161/files
- new: https://git.openjdk.org/jdk/pull/18161/files/1ad6997d..f82e432a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=18161&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=18161&range=01-02
Stats: 24 lines in 4 files changed: 3 ins; 14 del; 7 mod
Patch: https://git.openjdk.org/jdk/pull/18161.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/18161/head:pull/18161
PR: https://git.openjdk.org/jdk/pull/18161
More information about the core-libs-dev
mailing list