RFR: JDK-8315575: Retransform of record class with record component annotation fails with CFE [v3]
Serguei Spitsyn
sspitsyn at openjdk.org
Wed Mar 13 04:06:12 UTC 2024
On Wed, 13 Mar 2024 01:02:50 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> RecordComponent class has _attributes_count field.
>> The only user of the field is JvmtiClassFileReconstituter. Incorrect value of the field causes producing incorrect data for Record attribute.
>> Parsing Record attribute ClassFileParser skips unknown attributes and may skip RuntimeInvisibleAnnotations/RuntimeInvisibleTypeAnnotations.
>> Also annotations can be changed (added/removed) by class redefinition.
>> The fix removes attributes_count from RecordComponent; JvmtiClassFileReconstituter calculates correct attributes_count generating class bytes.
>>
>> Testing:
>> - tier1,tier2,hs-tier5-svc;
>> - redefineClasses/retransformClasses tests:
>> - test/jdk/java/lang/instrument
>> - test/hotspot/jtreg/serviceability/jvmti/RedefineClasses
>> - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses
>> - test/hotspot/jtreg/vmTestbase/nsk/jvmti/RetransformClasses
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>
> removed attributes_count from RecordComponent
Could you, please, update the CR with your analysis and conclusion about a root cause?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/18161#issuecomment-1993402337
More information about the core-libs-dev
mailing list