RFR: 8328066: WhiteBoxResizeTest failure on linux-x86: Could not reserve enough space for 2097152KB object heap

[Daniel Fuchs]

On Thu, 14 Mar 2024 04:11:14 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this test-only change which proposes to address https://bugs.openjdk.org/browse/JDK-8328066?
> 
> The test launches a JVM with 2G heap (`-Xmx2G`) and as noted in that issue, the failure was observed on linux-86 instance on a GitHub jobs run. 
> 
> The commit in this PR proposes to add relevant `@requires` so that the test is only run on 64 bit VM and expects the `os.maxMemory` to be > 2G.
> 
> The change has been tested on a linux-x86 run in GitHub actions job, plus even on local and CI 64 bit VM environments. No failures have been noticed.

LGTM.

I see that some other tests have things like:


* @requires vm.bits == "64" & os.maxMemory > 4G


Not sure what is the preferred form in such cases: two `@requires` or a single one?

-------------

Marked as reviewed by dfuchs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/18290#pullrequestreview-1936420903